This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Closed
Conversation
BREAKING CHANGE: `util.cid` now defaults to version 1 CIDs License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned
vmx
suggested changes
Feb 7, 2019
Member
vmx
left a comment
vmx
left a comment
There was a problem hiding this comment.
Could you please add a test that makes clear that it creates proper V0 CIDs if the version is passed in?
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
vmx
approved these changes
Feb 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 91.07% 91.01% -0.07%
==========================================
Files 13 13
Lines 269 267 -2
==========================================
- Hits 245 243 -2
Misses 24 24
Continue to review full report at Codecov.
|
18 tasks
5 tasks
Member
|
@alanshaw Is this still a thing or can it be closed? |
Member
|
Closing this one as I don't think it's relevant anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
util.cidnow defaults to version 1 CIDs and created CIDs are now base32 encoded by default when stringified.Depends on: